Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in DOC of Ranged Area #3055

Closed
januslian opened this issue May 13, 2023 · 1 comment · Fixed by #3064
Closed

Typos in DOC of Ranged Area #3055

januslian opened this issue May 13, 2023 · 1 comment · Fixed by #3064
Labels
bug

Comments

@januslian
Copy link

Hi,

I think there is a typo in the manual for ranged area(https://altair-viz.github.io/user_guide/marks/area.html#ranged-area). It says "For example, we can use ranged area with the ci0 and ci0". I think the second ci0 should be ci1.
@januslian januslian added the bug label May 13, 2023
@mattijn
Copy link
Contributor

mattijn commented May 13, 2023 •
edited
Loading

Thanks @januslian! Well spotted. I also think the example does not match the description, as I don't see usage of c0 and c1.

mattijn added a commit to mattijn/altair that referenced this issue May 19, 2023
@mattijn
Update area.rst
fa426f1 
Fix vega#3055.
This PR changes the description so it is in line with the example connected to it. 
I think the specification is good as is, so the emphasis is on the `alt.Y2` and not on the `ci0` and `ci1`.
@mattijn mattijn mentioned this issue May 19, 2023
Merged
mattijn added a commit that referenced this issue May 19, 2023
@mattijn
Update area.rst (#3064)
76f75d2 
Fix #3055.
This PR changes the description so it is in line with the example connected to it. 
I think the specification is good as is, so the emphasis is on the `alt.Y2` and not on the `ci0` and `ci1`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update area.rst mattijn/altair
2 participants
@mattijn @januslian