Skip to content

Commit

Permalink
perf: Improve performance of Chart.from_dict (#3383)
Browse files Browse the repository at this point in the history
* improve performance of Chart.from_dict

* ruff

* generate utils/schemapi.py automatically
  • Loading branch information
RobinL authored Mar 26, 2024
1 parent c7c4149 commit e20cdef
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion altair/utils/schemapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@
# class-level _class_is_valid_at_instantiation attribute to False
DEBUG_MODE: bool = True

jsonschema_version_str = importlib_version("jsonschema")


def enable_debug_mode() -> None:
global DEBUG_MODE
Expand Down Expand Up @@ -203,7 +205,6 @@ def _get_json_schema_draft_url(schema: dict) -> str:
def _use_referencing_library() -> bool:
"""In version 4.18.0, the jsonschema package deprecated RefResolver in
favor of the referencing library."""
jsonschema_version_str = importlib_version("jsonschema")
return Version(jsonschema_version_str) >= Version("4.18")


Expand Down
3 changes: 2 additions & 1 deletion tools/schemapi/schemapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
# class-level _class_is_valid_at_instantiation attribute to False
DEBUG_MODE: bool = True

jsonschema_version_str = importlib_version("jsonschema")


def enable_debug_mode() -> None:
global DEBUG_MODE
Expand Down Expand Up @@ -201,7 +203,6 @@ def _get_json_schema_draft_url(schema: dict) -> str:
def _use_referencing_library() -> bool:
"""In version 4.18.0, the jsonschema package deprecated RefResolver in
favor of the referencing library."""
jsonschema_version_str = importlib_version("jsonschema")
return Version(jsonschema_version_str) >= Version("4.18")


Expand Down

0 comments on commit e20cdef

Please sign in to comment.