BUG: fix to_dict() for nested selections

vega · Apr 29, 2020 · 1854ef0 · 1854ef0
1 parent 8f942ed
commit 1854ef0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/altair/vegalite/v3/api.py b/altair/vegalite/v3/api.py
@@ -169,10 +169,14 @@ def __repr__(self):
         return "Selection({0!r}, {1})".format(self.name, self.selection)
 
     def ref(self):
-        return {"selection": self.name}
+        return self.to_dict()
 
     def to_dict(self):
-        return {"selection": self.name}
+        return {
+            "selection": self.name
+            if isinstance(self.name, str)
+            else self.name.to_dict()
+        }
 
     def __invert__(self):
         return Selection(core.SelectionNot(**{"not": self.name}), self.selection)

diff --git a/altair/vegalite/v4/api.py b/altair/vegalite/v4/api.py
@@ -169,10 +169,14 @@ def __repr__(self):
         return "Selection({0!r}, {1})".format(self.name, self.selection)
 
     def ref(self):
-        return {"selection": self.name}
+        return self.to_dict()
 
     def to_dict(self):
-        return {"selection": self.name}
+        return {
+            "selection": self.name
+            if isinstance(self.name, str)
+            else self.name.to_dict()
+        }
 
     def __invert__(self):
         return Selection(core.SelectionNot(**{"not": self.name}), self.selection)