Merge pull request #1525 from jakevdp/properties-data

BUG: make it possible to pass data as a property
vega · May 22, 2019 · 0d191e7 · 0d191e7
2 parents 6d33ed7 + 74a908d
commit 0d191e7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/altair/vegalite/v3/api.py b/altair/vegalite/v3/api.py
@@ -537,7 +537,9 @@ def properties(self, **kwargs):
                 # For backward compatibility with old selection interface.
                 setattr(copy, key, {val.name: val.selection})
             else:
-                self.validate_property(key, val)
+                # Don't validate data, because it hasn't been processed.
+                if key != 'data':
+                    self.validate_property(key, val)
                 setattr(copy, key, val)
         return copy
 

diff --git a/altair/vegalite/v3/tests/test_api.py b/altair/vegalite/v3/tests/test_api.py
@@ -640,3 +640,11 @@ def test_repeat():
     assert 'columns' not in dct2
     assert dct2['spec']['encoding']['x']['field'] == {'repeat': 'row'}
     assert dct2['spec']['encoding']['y']['field'] == {'repeat': 'column'}
+
+
+def test_data_property():
+    data = pd.DataFrame({'x': [1, 2, 3], 'y': list('ABC')})
+    chart1 = alt.Chart(data).mark_point()
+    chart2 = alt.Chart().mark_point().properties(data=data)
+
+    assert chart1.to_dict() == chart2.to_dict()