Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save information that data were exported #176

Merged
merged 10 commits into from
Dec 20, 2018

Conversation

scardinius
Copy link
Contributor

Related to #157

@deepak-srivastava
Copy link
Collaborator

We need to make sure it doesn't break the site for civi versions before 5.8. At the moment export fails for earlier versions of civi with the error:
image
One solution could be providing default values for last 2 new argument in the export hook. That would also mean that the entity export methods don't action anything if component table or ids are missing.

@scardinius
Copy link
Contributor Author

@deepak-srivastava I added checking of version. Those new variables are available from 5.8.0
https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_export/#availability

@deepak-srivastava
Copy link
Collaborator

deepak-srivastava commented Dec 20, 2018

@scardinius Thanks, but that alone won't fix it because number of arguments in gdpr_civicrm_export() still differ - 4 vs 6, which is what php is complaining about.

@scardinius
Copy link
Contributor Author

@deepak-srivastava ah, yes, you're right. Added

@deepak-srivastava deepak-srivastava merged commit 70d8a70 into veda-consulting-company:master Dec 20, 2018
@deepak-srivastava
Copy link
Collaborator

Thanks @scardinius 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants