Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): Avoid alias in_flight_limit #5950

Merged
merged 6 commits into from
Jan 10, 2021
Merged

fix(config): Avoid alias in_flight_limit #5950

merged 6 commits into from
Jan 10, 2021

Conversation

ktff
Copy link
Contributor

@ktff ktff commented Jan 8, 2021

Closes #5920

A case of serde-rs/serde#1504.

@ktff
Avoid alias
0dfa82a 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff ktff added the domain: config Anything related to configuring Vector label Jan 8, 2021
@ktff ktff requested a review from fanatid January 8, 2021 22:36
@ktff ktff self-assigned this Jan 8, 2021
@ktff ktff requested review from bruceg and removed request for fanatid January 8, 2021 22:37
bruceg
bruceg reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good except for my beef with the .is_none() logic. Given the problems we've had with this, I think a test would be in order as well.

ktff added 3 commits January 8, 2021 23:50
@ktff
Use is_some
6bf5244 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff
Update test
481fa61 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff
Add test
b328b3e 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff ktff requested a review from bruceg January 8, 2021 23:09
bruceg
bruceg approved these changes Jan 8, 2021
View reviewed changes
ktff added 2 commits January 9, 2021 00:33
@ktff
Remove leftover
03d29e6 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff
Add dot
10cf0e1 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff ktff merged commit 808d0a6 into master Jan 10, 2021
@ktff ktff deleted the ktff/concurrency_alias_bug branch January 10, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruceg bruceg bruceg approved these changes

Assignees

@ktff ktff

Labels
domain: config Anything related to configuring Vector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request.in_flight_limit alias no longer works
2 participants
@ktff @bruceg