refactor: always warn error on register controller

vectier · Aug 11, 2022 · 9fe1311 · 9fe1311
1 parent 440376a
commit 9fe1311
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/lib/controllers/ControllerRegistry.js b/lib/controllers/ControllerRegistry.js
@@ -17,7 +17,7 @@ class ControllerRegistry {
     const controllerPath = controller.getPath();
     const routes = controller.getRouter();
 
-    if (process.env.NODE_ENV !== 'production' && this.#controllers.includes(controllerPath)) {
+    if (this.#controllers.includes(controllerPath)) {
       const controllerName = controller.constructor.name;
       console.warn(`Register duplicated controller: ${controllerPath} in ${controllerName}`);
     }

diff --git a/test/controller.test.ts b/test/controller.test.ts
@@ -6,20 +6,16 @@ import { MockConditionalMiddleware, MockMiddleware, PingPongMiddleware } from '.
 
 describe('Test the ControllerRegistry class implementation', () => {
 
-  const originalEnv = process.env;
   let expressApp: Express;
   let controllerRegistry: ControllerRegistry;
 
   beforeEach(() => {
-    process.env = { ...originalEnv };
-
     expressApp = express();
     controllerRegistry = new ControllerRegistry(expressApp);
   });
 
   afterEach(() => {
     jest.clearAllMocks();
-    process.env = originalEnv;
   });
 
   it('should registered the mock controllers correctly', () => {
@@ -30,16 +26,12 @@ describe('Test the ControllerRegistry class implementation', () => {
     expect(findRouter(expressApp).length).toBe(2);
   });
 
-  it('should warn an error correctly when register a duplicated controller', () => {
+  it('should warn an error when register a duplicated controller', () => {
     jest.spyOn(console, 'warn').mockImplementation(jest.fn());
 
     controllerRegistry.register(new MockIndexController());
     controllerRegistry.register(new MockIndexController());
 
-    // It should not warn when NODE_ENV is production
-    process.env.NODE_ENV = 'production'
-    controllerRegistry.register(new MockIndexController());
-
     expect(console.warn).toBeCalledTimes(1);
   });