-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable auto release #1890
Conversation
WalkthroughThis pull request updates three GitHub Actions workflow files to change their trigger mechanisms. The workflow in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub
participant Workflow
User->>GitHub: Manually trigger workflow_dispatch event
GitHub->>Workflow: Start workflow (on-tag / publish-sdk / rpc-proxy)
Workflow-->>GitHub: Workflow execution completes
Suggested Reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/rpc-proxy.yml (1)
7-10
: Review the Conditional Check
The job undertest
includes anif: github.ref != 'refs/tags/*'
condition. Since the workflow is now manually triggered, verify if this condition is still necessary or if it might lead to unexpected behavior under certain manual trigger scenarios.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 7-7: wrong indentation: expected 2 but found 4
(indentation)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/on-tag.yml
(1 hunks).github/workflows/publish-sdk.yml
(1 hunks).github/workflows/rpc-proxy.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
.github/workflows/rpc-proxy.yml (1)
3-5
: Manual Trigger Configuration Updated
The workflow's trigger has been successfully updated toworkflow_dispatch
, which now requires a manual start rather than an automatic invocation. This change aligns well with the PR objective to disable auto releases..github/workflows/publish-sdk.yml (1)
3-5
: Manual Trigger Enabled in Publish Workflow
The trigger has been switched toworkflow_dispatch
, which ensures that the publishing process will now only run when manually initiated. The permissions and steps remain intact, supporting the new workflow process..github/workflows/on-tag.yml (1)
3-5
: Workflow Trigger Switched to Manual Execution
The transition from an automatic tag-based trigger toworkflow_dispatch
meets the objective to disable auto releases. The file cleanly delegates job execution to the corresponding workflows, ensuring a centralized manual release process.
Description
Disables the on-tag release github workflows and instead they are changed to run manually
Type of change
Please delete options that are not relevant.
Checklist:
Summary by CodeRabbit