Allowing signasgaspayer on unsigned tx

[GrandinLuc]

Description

Allowing the use of signAsGasPayer with an unsigned transaction. In order to maintain backwards compatibility, for people using it with transactions that are signed by the sender, it returns the transaction with just the signature of the gas payer. Therefore, the resulting transaction object cannot be broadcasted right after, it needs to be manually rebuilt to contain both the sender and the gaspayer signature concatenated.

The way it would be done is like this:

const txSignedByGasPayer = tx.signAsGasPayer(sender, gasPayerPrivateKey);
const txSignedBySender = tx.signAsSender(senderPrivateKey);

const validTx = Transaction.of(tx_body, nc_utils.concatBytes(txSignedByGasPayer.signature, txSignedBySender.signature));

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

• Fixed unit tests

Test Configuration:

• Node.js Version:
• Yarn Version:

Checklist:

• My code follows the coding standards of this project
• I have performed a self-review of my code
• I have commented on my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• New and existing integration tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have not added any vulnerable dependencies to my code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Coverage

Summary

Lines	Statements	Branches	Functions
	99% (4390/4434)	97.13% (1392/1433)	98.9% (906/916)

Title	Tests	Skipped	Failures	Errors	Time
core	839	0 💤	0 ❌	0 🔥	2m 30s ⏱️
network	728	0 💤	0 ❌	0 🔥	5m 8s ⏱️
errors	40	0 💤	0 ❌	0 🔥	18.236s ⏱️
logging	3	0 💤	0 ❌	0 🔥	19.507s ⏱️
hardhat-plugin	19	0 💤	0 ❌	0 🔥	1m 5s ⏱️
aws-kms-adapter	23	0 💤	0 ❌	0 🔥	1m 27s ⏱️
ethers-adapter	5	0 💤	0 ❌	0 🔥	1m 19s ⏱️
rpc-proxy	37	0 💤	0 ❌	0 🔥	1m 27s ⏱️