1723 new net p1 code review and test thortransactions package #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Test CoverageSummary
|
claytonneal
requested changes
Mar 10, 2025
| @@ -30,7 +38,8 @@ class GetTxResponse { | |||
| return new Clause(clauseJSON); | |||
| }); | |||
| this.gasPriceCoef = UInt.of(json.gasPriceCoef); | |||
| this.gas = VTHO.of(json.gas); | |||
| // Each unit of gas is equal to 10^-5 VTHO (= 10^13 wei) | |||
| this.gas = VTHO.of(json.gas * Math.pow(10, 13), Units.wei); | |||
| @@ -51,7 +60,8 @@ class GetTxResponse { | |||
| expiration: this.expiration.valueOf(), | |||
| clauses: this.clauses?.map((clause) => clause.toJSON()), | |||
| gasPriceCoef: this.gasPriceCoef.valueOf(), | |||
| gas: Number(this.gas.wei), | |||
| // We convert back to gas units | |||
| gas: parseInt((this.gas.n * Math.pow(10, 5)).toString()), | |||
There was a problem hiding this comment.
We need a Gas class to VTHO conversion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review of the thorest/transactions package. Modified the way gas amount/price is handled with VTHO conversions. Added unit tests.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist: