build: 1.0.0-rc.5 #1568
Merged
build: 1.0.0-rc.5 #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request includes updates to the Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (15)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (12)
🔇 Additional comments (4)packages/ethers-adapter/package.json (2)
The version increment to 1.0.0-rc.5 follows semantic versioning and matches the PR objectives.
The SDK dependencies (@vechain/sdk-core, @vechain/sdk-errors, @vechain/sdk-network) are correctly synchronized to version 1.0.0-rc.5, maintaining consistency across the ecosystem. packages/aws-kms-adapter/package.json (2)
The version bump to ✅ Verification successfulVersion consistency verified across VeChain SDK packages All packages in the VeChain SDK ecosystem are consistently versioned at
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check version consistency across all package.json files
# Expected: All packages should be at version 1.0.0-rc.5
echo "Checking package versions..."
fd package.json --exec jq -r '. | select(.name | startswith("@vechain")) | [.name, .version] | @tsv'
Length of output: 445
The @vechain dependencies have been updated to match the new version. Let's verify:
✅ Verification successfulDependencies are consistent and secure The verification shows:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check dependencies and security advisories
# Check for any @vechain dependencies that might still be on rc.4
echo "Checking for inconsistent @vechain dependencies..."
fd package.json --exec jq -r '.dependencies | to_entries[] | select(.key | startswith("@vechain")) | select(.value | contains("rc.4")) | [.key, .value] | @tsv'
# Check for security advisories for fixed dependencies
echo "Checking security advisories for ethers 6.13.4..."
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: NPM, package: "ethers") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
echo "Checking security advisories for @aws-sdk/client-kms..."
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: NPM, package: "@aws-sdk/client-kms") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
Length of output: 1326 Script: #!/bin/bash
# Let's check all @vechain dependencies across package.json files
echo "Checking all @vechain dependencies..."
fd package.json --exec jq -r '
if .dependencies then
.dependencies | to_entries[] | select(.key | startswith("@vechain")) | [.key, .value] | @tsv
else
empty
end'
# Let's also check the fixed versions of other dependencies in aws-kms-adapter
echo -e "\nChecking other dependencies in aws-kms-adapter..."
cat packages/aws-kms-adapter/package.json | jq -r '.dependencies | to_entries[] | select(.key | startswith("@aws-sdk") or .key == "ethers") | [.key, .value] | @tsv'
Length of output: 1677 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@vechain/sdk-core@1.0.0-rc.4, npm/@vechain/sdk-hardhat-plugin@1.0.0-rc.4, npm/@vechain/sdk-network@1.0.0-rc.4 |
Test CoverageSummary
|
freemanzMrojo
approved these changes
Dec 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.0.0-rc.5 build.
Summary by CodeRabbit
New Features
1.0.0-rc.5.Bug Fixes
Chores