Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add code coverage for: Invalid signature case and No signature case in Certificate #56

Merged

Conversation

rodolfopietro97
Copy link
Contributor

Greetings again, team. I have created the following pull request aiming to enhance the code coverage of the certificate tests. Specifically, the proposed modifications target two instances:

  • The signature for verification of certificate is invalid
  • The signature for verification of certificate is not present

These amendments aim to improve the robustness and reliability of our bloom filter tests, ensuring a more comprehensive evaluation of its performance and functionality.

Code coverage BEFORE:

image

Code coverage AFTER:

image

* Invalid signature case
* No signature case
@coveralls
Copy link

Coverage Status

coverage: 91.837% (+0.5%) from 91.293% when pulling 52eadf4 on rodolfopietro97:increase-code-coverage-certificate into b35914b on vechain:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants