Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add coverage for: User defined number of bytes, Not found element into Bloom filter tests #55

Merged

Conversation

rodolfopietro97
Copy link
Contributor

@rodolfopietro97 rodolfopietro97 commented Jul 4, 2023

Greetings, team. I have created the following pull request aiming to enhance the code coverage of the bloom filter tests. Specifically, the proposed modifications target two instances:

  • Where the user determines the size of the bloom filter (when new instance is created).
  • The case where an item is not found within the bloom filter (when test function is called).

These amendments aim to improve the robustness and reliability of our bloom filter tests, ensuring a more comprehensive evaluation of its performance and functionality.

Code coverage BEFORE:

image
image

Code coverage AFTER:

image image

* User defined number of bytes
* Not found element
@coveralls
Copy link

Coverage Status

coverage: 91.837% (+0.5%) from 91.293% when pulling 8cf8ffe on rodolfopietro97:increase-code-coverage-bloom-filter into b35914b on vechain:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants