Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop resource
requests:
from gohelloworld
.
Resource requests are used to decide whether a pod may be scheduled on a node. In some of our downstream testing we have been seeing a rash of flakes in `TestHelmDeployPipelineRun` which manifest as follows. The pipeline itself times out waiting for the test to complete: ``` 2022-02-05T03:06:49.873527563Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:51.905640413Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:54.013351746Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:55.814048343Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:55.822633914Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:56.162347025Z stderr F Error: timed out waiting for the condition 2022-02-05T03:06:56.165538751Z stderr F helm.go:81: [debug] timed out waiting for the condition ``` However, a brief while later: ``` 2022-02-05T03:08:36.385531093Z stderr F 2022/02/05 03:08:36 Hello world sample started. 2022-02-05T03:08:37.246650188Z stderr F 2022/02/05 03:08:37 Hello world received a request. 2022-02-05T03:08:45.852975472Z stderr F 2022/02/05 03:08:45 Hello world received a request. 2022-02-05T03:08:45.856908405Z stderr F 2022/02/05 03:08:45 Hello world received a request. 2022-02-05T03:08:55.851238051Z stderr F 2022/02/05 03:08:55 Hello world received a request. 2022-02-05T03:08:55.855837089Z stderr F 2022/02/05 03:08:55 Hello world received a request. ``` I believe that the core issue here is that it times out because the pod cannot be scheduled, likely because the KinD cluster we're on is very busy. An alternative here might be to (dramatically) lower the resource requests, but I'm not sure they are providing any real value today. Related: tektoncd#4455
- Loading branch information