Skip to content

Commit

Permalink
WIP: remove pullrequest-init-build-base
Browse files Browse the repository at this point in the history
  • Loading branch information
imjasonh authored and tekton-robot committed Mar 29, 2022
1 parent 23a856d commit b5c45ec
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 20 deletions.
6 changes: 2 additions & 4 deletions .ko.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
defaultBaseImage: gcr.io/distroless/static:nonroot
baseImageOverrides:
# git-init uses a base image that supports running either as root or as user nonroot with UID 65532.
# git-init uses a base image that includes Git, and supports running either
# as root or as user nonroot with UID 65532.
github.com/tektoncd/pipeline/cmd/git-init: gcr.io/tekton-nightly/github.com/tektoncd/pipeline/git-init-build-base:latest

# PullRequest resource uses a distroless base image that supports running either as root or as user nonroot with UID 65532.
github.com/tektoncd/pipeline/cmd/pullrequest-init: gcr.io/tekton-nightly/github.com/tektoncd/pipeline/pullrequest-init-build-base:latest
6 changes: 0 additions & 6 deletions images/pullrequest-init/Dockerfile

This file was deleted.

8 changes: 0 additions & 8 deletions tekton/build-push-ma-base-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,6 @@ spec:
--no-cache \
$(workspaces.source.path)/images/git-init
#build multi-arch pullrequest-init build-base image
docker buildx build \
--platform "${PLATFORMS}" \
--tag ${IMAGE_REGISTRY}/${IMAGE_REGISTRY_PATH}/${PACKAGE}/pullrequest-init-build-base \
--push \
--no-cache \
$(workspaces.source.path)/images/pullrequest-init
volumeMounts:
- mountPath: /certs/client
name: dind-certs
Expand Down
3 changes: 1 addition & 2 deletions tekton/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,8 @@ spec:
$(params.package)/cmd/nop: ${COMBINED_BASE_IMAGE}
$(params.package)/cmd/workingdirinit: ${COMBINED_BASE_IMAGE}
# This matches values configured in .ko.yaml
$(params.package)/cmd/git-init: ${CONTAINER_REGISTRY}/$(params.package)/git-init-build-base:latest
# These match values configured in .ko.yaml
$(params.package)/cmd/pullrequest-init: ${CONTAINER_REGISTRY}/$(params.package)/pullrequest-init-build-base:latest
EOF
cat ${PROJECT_ROOT}/.ko.yaml
Expand Down

0 comments on commit b5c45ec

Please sign in to comment.