Skip to content

Commit

Permalink
Remove "use" of injection.Dynamic (not really used)
Browse files Browse the repository at this point in the history
See knative/pkg#2739. It doesn't seem it was
used anywhere anyway.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester committed Jul 28, 2023
1 parent 29d53d7 commit 4b8c9a1
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
6 changes: 0 additions & 6 deletions pkg/pipelinerunmetrics/injection.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ import (
func init() {
injection.Default.RegisterClient(func(ctx context.Context, _ *rest.Config) context.Context { return WithClient(ctx) })
injection.Default.RegisterInformer(WithInformer)

injection.Dynamic.RegisterDynamicClient(WithClient)
injection.Dynamic.RegisterDynamicInformer(func(ctx context.Context) context.Context {
ctx, _ = WithInformer(ctx)
return ctx
})
}

// RecorderKey is used for associating the Recorder inside the context.Context.
Expand Down
1 change: 0 additions & 1 deletion pkg/reconciler/events/cloudevent/cloudeventclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ func init() {
injection.Default.RegisterClient(func(ctx context.Context, _ *rest.Config) context.Context {
return withCloudEventClient(ctx)
})
injection.Dynamic.RegisterDynamicClient(withCloudEventClient)
}

// ceKey is used to associate the CloudEventClient inside the context.Context
Expand Down
6 changes: 0 additions & 6 deletions pkg/taskrunmetrics/injection.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ import (
func init() {
injection.Default.RegisterClient(func(ctx context.Context, _ *rest.Config) context.Context { return WithClient(ctx) })
injection.Default.RegisterInformer(WithInformer)

injection.Dynamic.RegisterDynamicClient(WithClient)
injection.Dynamic.RegisterDynamicInformer(func(ctx context.Context) context.Context {
ctx, _ = WithInformer(ctx)
return ctx
})
}

// RecorderKey is used for associating the Recorder inside the context.Context.
Expand Down

0 comments on commit 4b8c9a1

Please sign in to comment.