Skip to content

Commit

Permalink
Determine changeset from build information
Browse files Browse the repository at this point in the history
This updates knative.dev/pkg to @main to pick up a recent change to make
changeset.Get() determine the built version from information embedded in
the binary, and no longer return an error.

This also lets us remove symlinks for HEAD and refs in kodata, since
they were only there to enable the previous changeset.Get()
implementation.
  • Loading branch information
imjasonh authored and tekton-robot committed Aug 17, 2022
1 parent 8413f85 commit 27cb502
Show file tree
Hide file tree
Showing 20 changed files with 29 additions and 51 deletions.
1 change: 0 additions & 1 deletion cmd/controller/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/controller/kodata/refs

This file was deleted.

1 change: 0 additions & 1 deletion cmd/entrypoint/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/entrypoint/kodata/refs

This file was deleted.

1 change: 0 additions & 1 deletion cmd/git-init/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/git-init/kodata/refs

This file was deleted.

1 change: 0 additions & 1 deletion cmd/imagedigestexporter/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/imagedigestexporter/kodata/refs

This file was deleted.

1 change: 0 additions & 1 deletion cmd/kubeconfigwriter/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/kubeconfigwriter/kodata/refs

This file was deleted.

1 change: 0 additions & 1 deletion cmd/nop/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/nop/kodata/refs

This file was deleted.

1 change: 0 additions & 1 deletion cmd/pullrequest-init/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/pullrequest-init/kodata/refs

This file was deleted.

1 change: 0 additions & 1 deletion cmd/webhook/kodata/HEAD

This file was deleted.

1 change: 0 additions & 1 deletion cmd/webhook/kodata/refs

This file was deleted.

16 changes: 8 additions & 8 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ require (
go.uber.org/zap v1.21.0
golang.org/x/oauth2 v0.0.0-20220223155221-ee480838109b
gomodules.xyz/jsonpatch/v2 v2.2.0
k8s.io/api v0.23.8
k8s.io/apimachinery v0.23.8
k8s.io/client-go v0.23.8
k8s.io/code-generator v0.23.8
k8s.io/api v0.23.9
k8s.io/apimachinery v0.23.9
k8s.io/client-go v0.23.9
k8s.io/code-generator v0.23.9
k8s.io/klog v1.0.0
k8s.io/kube-openapi v0.0.0-20220124234850-424119656bbf
knative.dev/pkg v0.0.0-20220705130606-e60d250dc637
knative.dev/pkg v0.0.0-20220805012121-7b8b06028e4f
sigs.k8s.io/yaml v1.3.0
)

Expand Down Expand Up @@ -144,9 +144,9 @@ require (
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/apiextensions-apiserver v0.23.8 // indirect
k8s.io/gengo v0.0.0-20220307231824-4627b89bbf1b // indirect
k8s.io/klog/v2 v2.60.1-0.20220317184644-43cc75f9ae89 // indirect
k8s.io/apiextensions-apiserver v0.23.9 // indirect
k8s.io/gengo v0.0.0-20220613173612-397b4ae3bce7 // indirect
k8s.io/klog/v2 v2.70.2-0.20220707122935-0990e81f1a8f // indirect
k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 // indirect
sigs.k8s.io/json v0.0.0-20211208200746-9f7c6b3444d2 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect
Expand Down
36 changes: 19 additions & 17 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions pkg/pod/pod.go
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,7 @@ func (b *Builder) Build(ctx context.Context, taskRun *v1beta1.TaskRun, taskSpec
}

podAnnotations := kmeta.CopyMap(taskRun.Annotations)
version, err := changeset.Get()
if err != nil {
return nil, err
}
podAnnotations[ReleaseAnnotation] = version
podAnnotations[ReleaseAnnotation] = changeset.Get()

if readyImmediately {
podAnnotations[readyAnnotation] = readyAnnotationValue
Expand Down
6 changes: 1 addition & 5 deletions pkg/reconciler/taskrun/taskrun.go
Original file line number Diff line number Diff line change
Expand Up @@ -552,14 +552,10 @@ func (c *Reconciler) updateTaskRunWithDefaultWorkspaces(ctx context.Context, tr

func (c *Reconciler) updateLabelsAndAnnotations(ctx context.Context, tr *v1beta1.TaskRun) (*v1beta1.TaskRun, error) {
// Ensure the TaskRun is properly decorated with the version of the Tekton controller processing it.
version, err := changeset.Get()
if err != nil {
return nil, err
}
if tr.Annotations == nil {
tr.Annotations = make(map[string]string, 1)
}
tr.Annotations[podconvert.ReleaseAnnotation] = version
tr.Annotations[podconvert.ReleaseAnnotation] = changeset.Get()

newTr, err := c.taskRunLister.TaskRuns(tr.Namespace).Get(tr.Name)
if err != nil {
Expand Down

0 comments on commit 27cb502

Please sign in to comment.