Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extra space around the video after Vimeo Update #8

Merged
merged 2 commits into from
Nov 2, 2017

Conversation

hunzaboy
Copy link
Contributor

@hunzaboy hunzaboy commented Nov 2, 2017

There was some space around the top and bottom of the video once it is played. It happened recently due to some change on Vimeo side.

Fixed it in the PR.

Updated vimeo video container so that i embeds properly after the vimeo aspect ratio change.
Changed the vimeo aspect ratio to avoid extra background image on top and bottom of video.
@vb
Copy link
Owner

vb commented Nov 2, 2017

Thanks @hunzaboy 🥇

@vb vb merged commit db872a8 into vb:master Nov 2, 2017
@hunzaboy
Copy link
Contributor Author

hunzaboy commented Nov 2, 2017

Thank you for this wonderful script. Helped me a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants