Chore: Hide and show $el instead of $wrapper to be consistent with `d…

…etach` option
vast-engineering · Dec 10, 2018 · 4cd3b94 · 4cd3b94
1 parent 5ff5268
commit 4cd3b94
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/jquery.popupoverlay.js b/jquery.popupoverlay.js
@@ -239,7 +239,7 @@
             if (options.detach) {
                 $el.detach();
             } else {
-                $wrapper.hide();
+                $el.hide();
             }
         },
 
@@ -320,7 +320,7 @@
                 $wrapper.prepend(el);
                 $el.show();
             } else {
-                $wrapper.show();
+                $el.show();
             }
 
             opentimer = setTimeout(function() {
@@ -509,7 +509,7 @@
                         if (options.detach) {
                             $el.detach();
                         } else {
-                            $wrapper.hide();
+                            $el.hide();
                         }
                     }
 
@@ -533,7 +533,7 @@
                 if (options.detach) {
                     $el.detach();
                 } else {
-                    $wrapper.hide();
+                    $el.hide();
                 }
 
                 // Re-enable scrolling of background layer, if needed