fix:uri: "varlink help" not working with camel-case interface names #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The varlink specification does not mandate that interface names are lower-case so it is not possible to know if an uri string contains a member or not based on last member capitalization. This information must be provided by the caller depending on the context the URI is parsed. Signed-off-by: Samuel Cabrero <scabrero@suse.de>
samba-team-bot
pushed a commit
to samba-team/samba
that referenced
this pull request
Feb 20, 2025
$> varlink info unix:/run/systemd/userdb/org.samba.winbind Vendor: Samba Product: Winbind Version: 1 URL: https://samba.org Interfaces: io.systemd.UserDatabase org.varlink.service TODO libvarlink bug handling camel case interface names: varlink/libvarlink#58 $> varlink help unix:/run/systemd/userdb/org.samba.winbind/io.systemd.UserDatabase interface io.systemd.UserDatabase method GetUserRecord( uid: ?int, userName: ?string, service: string ) -> (record: object, incomplete: bool) method GetGroupRecord( gid: ?int, groupName: ?string, service: string ) -> (record: object, incomplete: bool) method GetMemberships( userName: ?string, groupName: ?string, service: string ) -> (userName: string, groupName: string) error NoRecordFound () error BadService () error ServiceNotAvailable () error ConflictingRecordFound () error EnumerationNotSupported () Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The varlink specification does not mandate that interface names are lower-case so it is not possible to know if an uri string contains a member or not based on last member capitalization.
This information must be provided by the caller depending on the context the URI is parsed.
Signed-off-by: Samuel Cabrero scabrero@suse.de