[RFC] Optimize message generation in object.c. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using printf-like functions when not necessary; this avoids scanning the string before writing it. Can be done for more files as well. To minimize the diff and logic differences, using only fputs instead of a combination of fputc and fputs might make sense.
|
Seems like a good compiler already does this ... http://www.ciselant.de/projects/gcc_printf/gcc_printf.html |
|
but yeah...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using printf-like functions when not necessary; this avoids
scanning the string before writing it.
Can be done for more files as well. To minimize the diff and logic
differences, using only fputs instead of a combination of fputc and
fputs might make sense.