Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible updates so Finemapr works with Finemap version 1.3.1 #6

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kathryntsai
Copy link

  • mainly updates to how input files are created, but there is still a bug because finemap 1.3 cannot read the z-file.

@variani
Copy link
Owner

variani commented Jul 11, 2019

Hi Kathryn,

Thank you for your contribution. I haven't worked on this project for a while. So I will spend some time to recover my design rules to keep all fine-mapping programs work together within my R interface.

Some thoughts:

  • we might want to have several versions of a program, e.g. finemap, to be supported;
    • Otherwise, always stick to the latest version and keep old classes, e.g. "FinemaprFinemapV1" for back compatibility and without any further support.
  • if I remember correctly, I aimed to give the same column names to, e.g. "snp" for genetic variant, inside my package, so generic functions in my package can be applied across programs/classes

Best,
Andrey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants