Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for new beta release of toolbox #324

Merged
merged 6 commits into from
Jun 15, 2020
Merged

Prep for new beta release of toolbox #324

merged 6 commits into from
Jun 15, 2020

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jun 15, 2020 •
edited
Loading

  • Improve the Dockerfile
  • Add .txt to LICENSE
  • Update dependencies
  • Apply the full CI matrix to tests
  • Prettify README a little

@gwynne
Update Dockerfile according to current usage
8aa4c2a 
- Simplify build step (no need to copy Swift libs anymore) and use explicit Ubuntu version for builder and runner
- Update runner image's packages, they're pretty outdated at the time of this writing, also install git so the toolbox can actually do anything
@gwynne gwynne added the enhancement New feature or request label Jun 15, 2020
@gwynne gwynne requested review from tanner0101, 0xTim and MrLotU June 15, 2020 10:16
@gwynne gwynne self-assigned this Jun 15, 2020
0xTim
0xTim approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd even be happy if you wanted to remove the Dockerfile altogether

MrLotU
MrLotU approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@MrLotU MrLotU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gwynne gwynne marked this pull request as ready for review June 15, 2020 11:31
@gwynne gwynne merged commit 30e007a into master Jun 15, 2020
@gwynne gwynne deleted the prep-for-new-beta-release branch June 15, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@MrLotU MrLotU MrLotU approved these changes

@tanner0101 tanner0101 Awaiting requested review from tanner0101

Assignees

@gwynne gwynne

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwynne @0xTim @MrLotU