Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing inline comments #130

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Fix parsing inline comments #130

merged 3 commits into from
Oct 30, 2018

Conversation

vi4m
Copy link
Contributor

@vi4m vi4m commented Oct 19, 2018 •
edited
Loading

Fixes bug: #127

Parsing in-line comment should not join following line.

  • Only-comment lines should be removed from output
  • End-of-line comments should not remove following line break

vi4m added 2 commits October 19, 2018 12:26
@vi4m
Fix #127
868257e 
Parsing in-line comment should not join following line.
@vi4m
Add regression tests for #127
4121f0e
@grundoon
Copy link
Member

Nitpick: a Swift Boolean should generally read as an assertion, usually using a verb such as is or contains – e.g. isEntirelyComment or lineContainsCommentOnly or...

@vi4m
Copy link
Contributor Author

vi4m commented Oct 23, 2018

I fixed comments. Is there anything else to do with this PR ?

tanner0101
tanner0101 approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tanner0101 tanner0101 added the enhancement New feature or request label Oct 30, 2018
@tanner0101 tanner0101 added this to the 3.0.2 milestone Oct 30, 2018
@tanner0101 tanner0101 self-assigned this Oct 30, 2018
@tanner0101 tanner0101 merged commit d35f54c into vapor:master Oct 30, 2018
@penny-coin
Copy link

Hey @vi4m, you just merged a pull request, have a coin!

You now have 1 coins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees

@tanner0101 tanner0101

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@vi4m @grundoon @penny-coin @tanner0101