-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Шаг "И Я закрыл все окна клиентского приложения кроме "Нужное окно"" не всегда закрывает все окна #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… develop # Conflicts: # lib/CF/83xddNoSync/Catalogs/ИерархическийСправочник.xml # lib/CF/83xddNoSync/Configuration.xml # tests/smoke/тесты_ОткрытиеФормКонфигурации/Тесты_ОткрытиеФормКонфигурации/Forms/УправляемаяФорма/Ext/Form/Module.bsl
artbear
requested changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почти отлично :)
есть небольшое замечание
...unner/step_definitions/РаботаСИнтерфейсом/РаботаСИнтерфейсом/Forms/Форма/Ext/Form/Module.bsl
Outdated
Show resolved
Hide resolved
...unner/step_definitions/РаботаСИнтерфейсом/РаботаСИнтерфейсом/Forms/Форма/Ext/Form/Module.bsl
Outdated
Show resolved
Hide resolved
artbear
reviewed
Feb 7, 2019
...unner/step_definitions/РаботаСИнтерфейсом/РаботаСИнтерфейсом/Forms/Форма/Ext/Form/Module.bsl
Outdated
Show resolved
Hide resolved
artbear
reviewed
Feb 7, 2019
...unner/step_definitions/РаботаСИнтерфейсом/РаботаСИнтерфейсом/Forms/Форма/Ext/Form/Module.bsl
Outdated
Show resolved
Hide resolved
artbear
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В одной конфигурации при запуске системы может открыться несколько окон, блокирующих интерфейс. В этом случае шаг "И Я закрыл все окна клиентского приложения кроме "Нужное окно"" закрывает не все окна. В результате, дальнейшие действия сценарного теста не выполняются. Предлагаю в будущем обновлении добавить проверку в конце процедуры "ЯЗакрылВсеОкнаКлиентскогоПриложенияКроме(ЗаголовокОкна)" на то, все ли окна закрылись.
@silverbulleters/Collaborators - просьба прокомментировать и проверить