Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Columns #126

Closed
MergimHo opened this issue May 20, 2021 · 4 comments
Closed

Configurable Columns #126

MergimHo opened this issue May 20, 2021 · 4 comments

Comments

@MergimHo
Copy link

Hi!,
very nice code. Thank you for that.

One suggestion: It may be beneficial to add configurable Columns, so that I can specificy whether a column should have a horizontal alignment right (e.G. if its a integer, like in excel) or in the middle or on the left.

Currently this is not possible as the settings are just on cell or row level.

@vandeseer
Copy link
Owner

Hey @MergimHo,

thanks for your request. Yes, you are right. A column does not support this as of now. I didn't really consider adding it until now but I can see at least one difficulty coming up. When having row spanning and column spanning the question is which setting (the row setting or the column setting) should get precedence? Or should it fall back to the setting from the table or the cell in this case? What if they are not set?

Still, I think you are right: It would add a bit of convenience if one could set different things already on the column level. But even then the question arises: If we set center alignment on column level and right alignment on row level what should happen?

Feel free to share your ideas on that issue! :)

Cheers,
Stefan

@MergimHo
Copy link
Author

Hi Stefan,
actually this is quite easy.
Most of the tables work that way that their type is determined by the column. Row-level types and the data along the colums is very rare.

So it would be good to allow Column-Level configuration. And if the user needs, overwrite that with row level configs.

vandeseer pushed a commit that referenced this issue May 24, 2021
vandeseer pushed a commit that referenced this issue May 24, 2021
@vandeseer
Copy link
Owner

This is now part of the develop branch and will be released with the next release. The precedence for the settings is: cell level has highest precedence, then column, then row and finally table level.

@vandeseer
Copy link
Owner

Released with 0.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants