-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug all tests #90
Merged
Merged
Debug all tests #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@siqizhu-uk - I've triggered the default PR test suite, let us see if they all run successfully |
@siqizhu-uk great work, thank you! Will aim to fix the issues causing current GH workflow failures in the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Debug all tests(slow and not slow).
test_weighted_ensemble_explainer
Failuretests/plugins/ensemble/test_classifier.py::test_weighted_ensemble_explainer
was failing due to a shape mismatch in theexplain
method's result from theKernelSHAPPlugin
explainer for classification tasks.shap
(shap>=0.45.0
), theshap_values
implementation returns anndarray
with the shape(samples x features x output)
, which differs from the previous format(output x samples x features)
for models with vector outputs.explain
method insrc/autoprognosis/plugins/explainers/plugin_kernel_shap.py::KernelSHAPPlugin::explain
to align with the new behavior for classification tasks.test_surv_app
Failuretests/apps/test_survival_app.py::test_surv_app
was failing due to a missing required parameter."extras_cbk"
parameter toNewRiskEstimationAppProto
, setting its default value toNone
.@DrShushen changes:
pandas
1 --> 2 relatedAttributeError: 'DataFrame' object has no attribute 'append'
, insrc/autoprognosis/plugins/explainers/plugin_risk_effect_size.py::RiskEffectSizePlugin._get_population_shifts
a call to<dataframe>.append
was replaced withpd.concat()
, which should make this pandas 1 and 2 compatible.tests/plugins/uncertainty/test_cohort_explainer.py::test_fit/test_predict_classifier
failing due to not getting any important features from"risk_effect_size"
explainer,effect_size: float
parameter added toCohortExplainerPlugin
and set to a value lower value in the test.actions/setup-python@v1
tov5
in GitHub workflows to avoid python setup errors.test_surv_search
test, to make the test more stable.Affected Dependencies
shap
to be >= 0.45.0 to avoidshap_values
return shape mismatch as mentioned in Description.How has this been tested?
tests
directoryChecklist