Private key security updates/fixes

[angrybayblade]

Proposed changes

This PR

• Fixes the start.sh script to use password if provided when issuing certificates
• Updates the documentation on private key security in deployments

Fixes

fixes #2088
fixes #2089

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

• Non-breaking fix (non-breaking change which fixes an issue)
• Breaking fix (breaking change which fixes an issue)
• Non-breaking feature (non-breaking change which adds functionality)
• Breaking feature (breaking change which adds functionality)
• Refactor (non-breaking change which changes implementation)
• Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING doc
• I am making a pull request against the main branch (left side). Also you should start your branch off our main.
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have locally run services that could be impacted and they do not present failures derived from my changes
• Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
• Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7dab1ca) 94.13% compared to head (73037ec) 94.13%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2108   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         255      255           
  Lines       15810    15810           
=======================================
  Hits        14883    14883           
  Misses        927      927           

Flag	Coverage Δ
unittests	94.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[angrybayblade]

Fixes #2088

[jmoreira-valory]

trader-quickstart related PR valory-xyz/trader-quickstart#55 has been updated to latest branch (now on develop branch):

• Issue Password stored in clear in deployment files #2089 seems to be resolved in this PR.
• Issue Framework fails when running with password-protected keys #2088 has not been resolved yet. Please, see the detailed comments on that issue.

[jmoreira-valory]

Steps to test this PR:

Build the agent image according to this PR:

cd open-autonomy/deployments/Dockerfiles/autonomy
docker build . -t valory/open-autonomy:rc0

Edit file open-autonomy/autonomy/data/Dockerfiles/agent/Dockerfile
Change
FROM ${AUTONOMY_IMAGE_NAME}:${AUTONOMY_IMAGE_VERSION}
by
FROM ${AUTONOMY_IMAGE_NAME}:rc0

Reinstall framework from local directory:

pip3 install -e ../../open-autonomy

@angrybayblade you can now mark issues #2108 and #2088 as completed.