Optimise images #2066
Merged
Optimise images #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include install and build scripts in the base image - Remove unwanted layers - Remove unwanted data files
angrybayblade
commented
Sep 27, 2023
Comment on lines
-9
to
-10
| COPY start.sh /home/ubuntu | ||
| COPY install.sh /home/ubuntu |
There was a problem hiding this comment.
Will be included in the base image
|
|
||
| WORKDIR /home/ubuntu | ||
| ENV PATH=$PATH:/home/ubuntu/.local/bin | ||
| COPY scripts /root/scripts |
There was a problem hiding this comment.
Install and runner scripts
Comment on lines
-9
to
-13
| RUN sudo apt-get update --fix-missing | ||
| RUN sudo apt-get autoremove | ||
| RUN sudo apt-get autoclean | ||
| RUN sudo apt-get install python3.10 python3.10-dev git cmake autoconf automake build-essential libffi-dev libtool pkg-config -y | ||
| RUN cd /usr/bin && sudo rm python3 && sudo ln -s python3.10 python3 && sudo ln -s python3.10 python |
There was a problem hiding this comment.
No need to install the python interpreters and dev libraries, they are included in the base image
| RUN sudo apt-get install net-tools -y | ||
| RUN python -m pip install --upgrade pip | ||
|
|
||
| COPY openssl.cnf /etc/ssl |
There was a problem hiding this comment.
Included in the base image
Comment on lines
-1
to
-4
| open-aea[all]>=1.40.0,<2.0.0 | ||
| open-aea-cli-ipfs>=1.40.0,<2.0.0 | ||
| protobuf>=4.21.6,<5.0.0 | ||
| requests==2.27.1 |
There was a problem hiding this comment.
Already included in the base image
Release `v0.13.0`
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bump/oaea-1-40-0 #2066 +/- ##
===================================================
Coverage ? 94.23%
===================================================
Files ? 263
Lines ? 15956
Branches ? 0
===================================================
Hits ? 15036
Misses ? 920
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dvilelaf
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.