Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get tx receipt should return even if reverted tx #773

Merged
merged 13 commits into from
Dec 12, 2024

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented Dec 10, 2024

Fixes

Get tx receipt should return the receipt even if the tx has reverted.

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@Adamantios
Copy link
Collaborator

Adamantios commented Dec 10, 2024

We already have a WIP in #772 for bumping macos version, which fixes one of two issues that surface, in eb07e29. I would suggest you to ignore the mac tests until this is merged.

attempts = 0
while (
not is_settled
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we will try verifying a failed tx.

@0xArdi 0xArdi merged commit 436e63e into main Dec 12, 2024
32 checks passed
@0xArdi 0xArdi deleted the fix/get-tx-receipt-failed-txs branch December 12, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants