forked from fetchai/agents-aea
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pricing #756
Merged
Merged
Fix pricing #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
force-pushed
the
fix/pricing
branch
from
September 13, 2024 18:03
6e48c8f
to
dfeaee4
Compare
Make the default priority fee optional and always apply it when present. Remove the unnecessary `priority_fee_estimation_trigger` which is causing issues with dynamic pricing.
Adamantios
force-pushed
the
fix/pricing
branch
from
September 13, 2024 18:24
dfeaee4
to
7eb0ad9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 90.21% 90.09% -0.13%
==========================================
Files 373 331 -42
Lines 29899 29567 -332
==========================================
- Hits 26974 26638 -336
- Misses 2925 2929 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Adamantios
commented
Sep 14, 2024
Adamantios
force-pushed
the
fix/pricing
branch
from
September 16, 2024 12:19
43771f2
to
f137ea4
Compare
0xArdi
reviewed
Sep 16, 2024
0xArdi
previously approved these changes
Sep 17, 2024
solarw
previously approved these changes
Sep 17, 2024
Release `v1.56.0`
0xArdi
approved these changes
Sep 17, 2024
solarw
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes the pricing logic.
Fixes
Closes #735.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.Further comments
n/a