Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shutil.copytree isntead of outdated distutils.dir_util #558

Closed
wants to merge 1 commit into from

Conversation

solarw
Copy link
Collaborator

@solarw solarw commented Jan 23, 2023

Proposed changes

use shutil.copytree isntead of outdated distutils.dir_util

Fixes

#553

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

DELETE INCLUSIVE THIS AND BELOW FOR STANDARD PR

Release summary

Version number: [e.g. 1.0.1]

Release details

Describe in short the main changes with the new release.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side), from develop
  • Lint and unit tests pass locally and in CI
  • I have checked the fingerprint hashes are correct by running (aea packages lock --check)
  • I have regenerated the latest API docs
  • I built the documentation and updated it with the latest changes
  • I have added an item in HISTORY.md for this release
  • I bumped the version number in the aea/__version__.py file.
  • I bumped the version number in every Docker image of the repo and published it. Also, I built and published them with tag latest
    (check the READMEs of aea-develop
    and aea-user)
  • I have pushed the latest packages to the registry.
  • I have uploaded the latest aea to PyPI.
  • I have uploaded the latest plugins to PyPI.

Further comments

Write here any other comment about the release, if any.

@solarw solarw force-pushed the fix/use_shutil_copy_tree branch from c9f3859 to 1bcce42 Compare January 24, 2023 07:27
@solarw
Copy link
Collaborator Author

solarw commented Jan 24, 2023

@DavidMinarsch @angrybayblade
to be compatible with all the tests shutil.copytree requires dirs_exist_ok=True option, introduced in python 3.8.

so it's not compatible with python3.7 and this PR is meaningless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants