Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional kwargs to SEND_TRANSACTION messages #693

Closed
0xArdi opened this issue Nov 20, 2023 · 0 comments · Fixed by #695
Closed

Add optional kwargs to SEND_TRANSACTION messages #693

0xArdi opened this issue Nov 20, 2023 · 0 comments · Fixed by #695
Labels
bug Something isn't working

Comments

@0xArdi
Copy link
Collaborator

0xArdi commented Nov 20, 2023

The ledger connection expects that ledger messages contain a kwargs field:
https://github.com/valory-xyz/open-aea/blob/main/packages/valory/connections/ledger/ledger_dispatcher.py#L473

SignedTransaction doesnt have a kwargs field. https://github.com/valory-xyz/open-aea/blob/main/aea/helpers/transaction/base.py#L219
@DavidMinarsch DavidMinarsch added the bug Something isn't working label Nov 21, 2023
@angrybayblade angrybayblade mentioned this issue Nov 28, 2023
Merged
10 tasks
angrybayblade added a commit that referenced this issue Jan 4, 2024
@angrybayblade
Merge pull request #695 from valory-xyz/fix/#693
39a82fd 
Add kwargs field to `SignedTransaction`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add kwargs field to SignedTransaction valory-xyz/open-aea
2 participants
@DavidMinarsch @0xArdi