Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/bump oa 0.3.1 #29

Merged
merged 5 commits into from
Sep 27, 2022
Merged

chore/bump oa 0.3.1 #29

merged 5 commits into from
Sep 27, 2022

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented Sep 26, 2022

This PR bumps the repo to open-autonomy@v0.3.1 and open-aea@1.20.0.

@0xArdi 0xArdi force-pushed the chore/bump-oa-0.3.1 branch from 1424bdc to f46cdfd Compare September 26, 2022 19:19
@0xArdi
Copy link
Collaborator Author

0xArdi commented Sep 26, 2022

python/mypy#13627
Pinning to py3.10.6 to avoid the static checks failing.
The ultimate fix should use a version of mypy that doesn't have this issue.

@DavidMinarsch DavidMinarsch changed the base branch from test/pool-manager-fsm to main September 27, 2022 07:46
@@ -72,7 +72,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: [ "3.10" ]
python-version: [ "3.10.6" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so explicit? I think we shouldn't do that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has to do with this.

It's not architecture dependent, it's only about the specific version of Python you have in your image. If you have Python 3.10.7 you'll see the error, if you have Python 3.10.6 you won't. In all cases, upgrading to mypy 0.981 will fix.

I can reproduce the problem locally when running tox -e mypy.

@@ -21,8 +21,8 @@
"skill/valory/transaction_settlement_abci/0.1.0": "bafybeia2gs36s2mz32yaznhlidiolhw5swkumiej4vgwywphppjvurldie",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update this to the matching hashes here: https://github.com/valory-xyz/open-autonomy/blob/v0.3.1/packages/packages.json

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hashes are correct, and that is on accident.
What happened is I had #27 and #29 on my local. As I was bumping to v0.3.1 I needed to add a fix to #27, the local packages were from v0.3.1 and were updated when I ran make generators.

@0xArdi 0xArdi mentioned this pull request Sep 27, 2022
@DavidMinarsch DavidMinarsch merged commit aa39fcf into main Sep 27, 2022
@DavidMinarsch DavidMinarsch deleted the chore/bump-oa-0.3.1 branch September 27, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants