Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT is not received by User B if user has skipped the phone number and later verifies it via CTA / Settings / Rewards screen #2798

Closed
ValoraQA opened this issue Aug 18, 2022 · 9 comments
Labels
bug Something isn't working Priority: P1 Critical qa-report wallet

Comments

@ValoraQA
Copy link

Frequency : 100%

Repro on build version: iOS TestFlight release build V:1.38.2, Android internal release build V:1.38.2
Repro on device : iPhone 12(14.7.1), iPhone 13 mini (15.1.1), Google Pixel 2XL(11.0) , Google Pixel XL(10.0)

Pre-condition:
1] User A must have installed the application
2] User A must have send an invite link to User B

Repro Steps :
1] User B must skip the phone number verification
2] It should redirect to homepage and no activity should be seen
3] Now connect and verify the phone number via in-app CTA / Settings / Rewards screen
4] Observe the acitivies seen on homepage

Bug : Nft is not received once the number is confirmed via CTA / Settings / Rewards screen and only amount is received

Expected Behavior : NFT should also be received once the phone number is confirmed

Investigation : Only amount is seen received once the user confirms the phone number

Attachment : NoNFT.mp4
Bug Observed at 3.03. seconds

@ValoraQA ValoraQA added bug Something isn't working Priority: P1 Critical wallet qa-report labels Aug 18, 2022
@kathaypacific
Copy link
Collaborator

Hi @ValoraQA can you please share the address you used to send the invite, and the address of the newly verified account?

@kathaypacific
Copy link
Collaborator

there are some checks on the backend that will not distribute rewards if the inviter or invitee are not eligible. the maximum allowed number of rewards per user is 3, is there a chance you have exceeded this limit already for the account you used to send the invite?

@jh2oman
Copy link
Contributor

jh2oman commented Aug 18, 2022

I actually skipped verification when I tested during bugapalooza and I was still able to receive my nft by verifying phone number via settings

@ellenwoconnor
Copy link

Hmm. it sounds like the hunch is that this is an eligibility limitation. i think we have this logged, right? can we confirm?

@ValoraQA
Copy link
Author

Hey @kathaypacific the sender address is : 0xa8c50e6ca28fa46a2fbaa4d128fd96003b99ee68 and the receiver address is : 0xe8999d5e092b718577b918a29b5994e49282d26f

  • We tried without verifying phone number and NFT was not received , so we confirmed the phone number and invite amount was received but NFT was not received
  • This might be the case where limit of sending invite from single account was exhausted
  • There is no mentioning of NFT limit in the PR link

CC: @jh2oman @MuckT @ellenwoconnor

@MuckT
Copy link
Collaborator

MuckT commented Aug 19, 2022

@ValoraQA is it possible to test with a new accounts and phone numbers?

@kathaypacific
Copy link
Collaborator

@ellenwoconnor i checked the db and sender 0xa8c50e6ca28fa46a2fbaa4d128fd96003b99ee68 already received 3 invite rewards to invitees 0xe866e44e0465cf0c26b47c0d55f706f2fd5fb45b, 0x3cba41329f5c52b0e5418dfd0105b479e656f39a, 0x3cf76b716716da3a08862901ba18956a71e1f6a2. all of these rewards were created on the 18th of august. therefore this is not a valid bug, as it's expected that the user stops receiving rewards after 3.

@ValoraQA this limit is implemented on the backend.

@MuckT the invite rewards were turned off yesterday. it seems that this inviter address from the QA team was already able to perform 3 successful invites with rewards, so i also don't think we need to do more testing.

i'm going to close this ticket, if anyone feels strongly feel free to reopen

@ValoraQA
Copy link
Author

ValoraQA commented Aug 19, 2022

Hey @kathaypacific we again tried for existing account address : 0x225467aaa0994ef88b9468e7c89f0265b93e259e and invite was sent to this address : 0x238f1c3c4f34c814aa8631d0097474ca4bbf50fe and we still didn't receive NFT
Can you please check and provide us details for it ?

Note : "0x225467aaa0994ef88b9468e7c89f0265b93e259e" - This address is associated with Indian number (sender)
0x238f1c3c4f34c814aa8631d0097474ca4bbf50fe - This address is associated with US number (invitee)

Is there any restriction that it can be sent only to US numbers and not other countries , because we tried for US and France numbers and vice versa , and we were able to receive NFT as gift

Can you please take a look

Thanks

CC: @MuckT

@kathaypacific
Copy link
Collaborator

Hi @ValoraQA , as i mentioned in my above comment (#2798 (comment)) the invite rewards is turned off now and no longer available for testing. there is no region requirement for participationg in the program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: P1 Critical qa-report wallet
Projects
None yet
Development

No branches or pull requests

5 participants