fix: fix undefined properties issue #309
Conversation
|
|
||
| for (const address of Object.keys(transformData)) { | ||
| expect( | ||
| Object.values(transformData[address]).every(isNotUndefined), |
There was a problem hiding this comment.
nit: perhaps it'd be the most robust just to declare the expected data in full? (in case expected properties are missing, this test would then fail)
There was a problem hiding this comment.
@kathaypacific I'm not sure that I interpreted your suggestion correctly, here are my thoughts so far:
the property set has a dynamic nature, depending on the character of the coin. e.g. stable coins have isFeeCurrency or isSupercharged, others do not.
we can ensure that if token is, for instance, "Celo" it should have certain properties, but it seems to me having not too much value. effectively we are making a snapshot of what's in a json file.
for basic required properties we have a schema validation, which aims to ensure that at least required values are present.
in this specific case I wanted only ensure that we are not submitting any undefined properties to RTDB, because it throws an error seeing that, and apparently there is no way to make it ignore them (although this is possible in Firestore)
There was a problem hiding this comment.
okay makes sense, happy for you to also leave it like this
Fixing an issue introduced in #306: tokens not having
isFeeCurrencyproperty programmatically receivedisCoreToken: undefinedproperty which caused RTDB update to fail.Test plan
Updated unit tests
Related issues
Related to RET-899