Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct click version requirement to >= 7.0 #81

Merged
merged 1 commit into from
May 23, 2019
Merged

Correct click version requirement to >= 7.0 #81

merged 1 commit into from
May 23, 2019

Conversation

akx
Copy link
Member

@akx akx commented May 23, 2019

We need the show_envvar kwarg since 1a0f77b.

It was added in pallets/click#710 and released in Click 7.0.

We need the show_envvar kwarg since 1a0f77b
which was added in pallets/click#710 and released in Click 7.0.
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #81 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage    86.4%   86.32%   -0.08%     
==========================================
  Files          95       95              
  Lines        2677     2677              
  Branches      372      372              
==========================================
- Hits         2313     2311       -2     
- Misses        235      236       +1     
- Partials      129      130       +1
Impacted Files Coverage Δ
valohai_cli/commands/parcel.py 67.01% <0%> (-2.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd8e97...0161fdb. Read the comment docs.

@akx akx merged commit 9ed88cb into master May 23, 2019
@akx akx deleted the click-version branch May 23, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant