Fix memory leak in test_quicklist.c unit test #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In last daily run we had the following failure: ``` test — compress and decomress quicklist plain node large than UINT32_MAX [test_quicklistCompressAndDecomressQuicklistPlainNodeLargeThanUINT32MAX - unit/test_quicklist.c:2288] Compress and decompress: 4096 MB in 39.27 seconds. [ok] - test_quicklist.c:test_quicklistCompressAndDecomressQuicklistPlainNodeLargeThanUINT32MAX [END] - test_quicklist.c: 58 tests, 58 passed, 0 failed [START] - test_rax.c [test_raxRandomWalk - unit/test_rax.c:548] Failed assertion: raxAllocSize(t) == zmalloc_used_memory() [fail] - test_rax.c:test_raxRandomWalk ``` Job Link: https://github.com/valkey-io/valkey/actions/runs/13555915665/job/37890070586 Although the assert that failed was in a `test_rax.c` test function, the problem was in the last test function from the `test_quicklist.c` unit test that ran just before the test that failed. The `test_quicklistCompressAndDecomressQuicklistPlainNodeLargeThanUINT32MAX` test function was not freeing the string allocated in the beginning of the test. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
madolson
approved these changes
Feb 27, 2025
zuiderkwast
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In last daily run we had the following failure:
Job Link: https://github.com/valkey-io/valkey/actions/runs/13555915665/job/37890070586
Although the assert that failed was in a
test_rax.ctest function, the problem was in the last test function from thetest_quicklist.cunit test that ran just before the test that failed.The
test_quicklistCompressAndDecomressQuicklistPlainNodeLargeThanUINT32MAXtest function was not freeing the string allocated in the beginning of the test.