Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect address sanitizer with Clang #1712

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

zuiderkwast
Copy link
Contributor

@zuiderkwast zuiderkwast commented Feb 11, 2025

Fixes the failure trying to use dlopen with DEEPBIND with ASAN when compiling with Clang:

==90510==You are trying to dlopen a /home/runner/work/valkey/valkey/tests/modules/keyspecs.so shared library with RTLD_DEEPBIND flag which is incompatible with sanitizer runtime (see google/sanitizers#611 for details). If you want to run /home/runner/work/valkey/valkey/tests/modules/keyspecs.so library under sanitizers please remove RTLD_DEEPBIND from dlopen flags.

https://github.com/valkey-io/valkey/actions/runs/13261241213/job/37018133361

The previous check only covers GCC.

Additionally, don't require GLIBC when FreeBSD is used. FreeBSD has it's own libc which supports DEEPBIND according to its docs.

Follow-up of #1703, #1707

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Copy link
Member

@rjd15372 rjd15372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuiderkwast Thanks for fixing this!

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.12%. Comparing base (4e0149a) to head (7ed5500).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1712      +/-   ##
============================================
+ Coverage     71.11%   71.12%   +0.01%     
============================================
  Files           123      123              
  Lines         65541    65541              
============================================
+ Hits          46610    46619       +9     
+ Misses        18931    18922       -9     
Files with missing lines Coverage Δ
src/module.c 9.61% <ø> (ø)

... and 14 files with indirect coverage changes

@zuiderkwast zuiderkwast merged commit 4467556 into valkey-io:unstable Feb 11, 2025
50 checks passed
@zuiderkwast zuiderkwast deleted the asan-clang branch February 11, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants