Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for cross-version-replication test #1644

Conversation

zuiderkwast
Copy link
Contributor

Fixes #1641

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Copy link
Collaborator

@hpatro hpatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarthakaggarwal97 Feel free to explore the reason why the "other server" approach takes longer to sync compared to regular test. I'm closing this out as it's making the CI unstable.

@hpatro hpatro merged commit 12ec3d5 into valkey-io:unstable Jan 29, 2025
47 checks passed
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.99%. Comparing base (4b8f3ed) to head (59aa036).
Report is 3 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #1644   +/-   ##
=========================================
  Coverage     70.98%   70.99%           
=========================================
  Files           121      121           
  Lines         65176    65176           
=========================================
+ Hits          46267    46271    +4     
+ Misses        18909    18905    -4     

see 12 files with indirect coverage changes

@zuiderkwast zuiderkwast deleted the fix-flaky-cross-version-replication-test branch January 29, 2025 21:59
enjoy-binbin pushed a commit to enjoy-binbin/valkey that referenced this pull request Feb 2, 2025
Fixes valkey-io#1641

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-failure] Flaky test failure with cross version replication test
2 participants