Changes tcmalloc.h header location
#1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the `tcmalloc.h` header location from the deprecated location `google/` to `gperftools/`. *Why we're doing this now?* The location `google/tcmalloc.h` has been deprecated for more than 10 years in favor of `gperftools/tcmalloc.h`, and the deprecated location will be removed in the next release of gperftools. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
3f592c6 to
acd74b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1039 +/- ##
============================================
+ Coverage 70.58% 70.63% +0.05%
============================================
Files 114 114
Lines 61670 61670
============================================
+ Hits 43530 43561 +31
+ Misses 18140 18109 -31 |
hwware
approved these changes
Sep 17, 2024
zuiderkwast
approved these changes
Sep 23, 2024
tcmalloc.h header location (#1033)tcmalloc.h header location
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Oct 10, 2024
This commit changes the `tcmalloc.h` header location from the deprecated location `google/` to `gperftools/`. **Why we're doing this now?** The location `google/tcmalloc.h` has been deprecated for more than 10 years in favor of `gperftools/tcmalloc.h`, and the deprecated location will be removed in the next release of gperftools. Fixes valkey-io#1033 Signed-off-by: Ricardo Dias <ricardo.dias@percona.com> Signed-off-by: naglera <anagler123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
tcmalloc.hheader location from the deprecated locationgoogle/togperftools/.Why we're doing this now?
The location
google/tcmalloc.hhas been deprecated for more than 10 years in favor ofgperftools/tcmalloc.h, and the deprecated location will be removed in the next release of gperftools.Fixes #1033