Skip to content

Commit

Permalink
Migrate binaries build to ARM github runners (#1790)
Browse files Browse the repository at this point in the history
This PR migrates the workflows to run on github hosted arm runners for each ubuntu version that is currently supported. It is much faster than the emulated version that used to take around 21 mins. Currently, it takes around 4-5 mins.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
  • Loading branch information
roshkhatri authored Feb 27, 2025
1 parent b3e5e8a commit f7c6d31
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
},
{
"arch": "arm64",
"target": "ubuntu20.04",
"target": "ubuntu-22.04-arm",
"type": "deb",
"platform": "focal"
"platform": "jammy"
},
{
"arch": "arm64",
"target": "ubuntu22.04",
"target": "ubuntu-24.04-arm",
"type": "deb",
"platform": "jammy"
"platform": "noble"
}
]
}
12 changes: 5 additions & 7 deletions .github/workflows/call-build-linux-arm-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
build-valkey:
# Capture source tarball and generate checksum for it
name: Build package ${{ matrix.distro.target }} ${{ matrix.distro.arch }}
runs-on: "ubuntu-24.04-arm"
runs-on: ${{matrix.distro.target}}
strategy:
fail-fast: false
matrix: ${{ fromJSON(inputs.build_matrix) }}
Expand All @@ -51,13 +51,11 @@ jobs:
aws-region: ${{ inputs.region }}
role-to-assume: ${{ secrets.role_to_assume }}

- name: Install dependencies
run: sudo apt-get update && sudo apt-get install -y build-essential libssl-dev libsystemd-dev

- name: Make Valkey
uses: uraimo/run-on-arch-action@v2
with:
arch: aarch64
distro: ${{matrix.distro.target}}
install: apt-get update && apt-get install -y build-essential libssl-dev libsystemd-dev
run: make -C src all BUILD_TLS=yes USE_SYSTEMD=yes
run: make -C src all BUILD_TLS=yes USE_SYSTEMD=yes

- name: Create Tarball and SHA256sums
run: |
Expand Down

0 comments on commit f7c6d31

Please sign in to comment.