Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR Template to no longer request updating the Changes File/Potentially Remove the CHANGES file #31

Closed
kjaymiller opened this issue Jul 1, 2024 · 1 comment · Fixed by #37
Closed

Update PR Template to no longer request updating the Changes File/Potentially Remove the CHANGES file #31

kjaymiller opened this issue Jul 1, 2024 · 1 comment · Fixed by #37

Comments

@kjaymiller
Copy link
Contributor

Based on the comment in PR #27

  1. ignore the CHANGES file, it wasn't really used much recently and we have a nice bot that can summarize changes in releases from PRs. It isn't perfect, but for now let's just use that (you don't have to do anything).

Originally posted by @aiven-sal in #27 (review)
@aiven-sal
Copy link
Member

We should also add a not inside the CHANGES file to make it clear that it isn't used anymore.

This was referenced Jul 3, 2024
Closed
Merged
aiven-sal added a commit to kjaymiller/valkey-py that referenced this issue Jul 5, 2024
@aiven-sal
Remove CHANGES file as originally proposed
7c0afad 
in issue valkey-io#31

Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kjaymiller @aiven-sal