Added zremRangeByScore command in Node. #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2618966 to
85cd403
Compare
ec7b644 to
c5bffdf
Compare
barshaul
reviewed
Mar 6, 2024
node/src/BaseClient.ts
Outdated
| @@ -1171,6 +1172,24 @@ export class BaseClient { | |||
| return this.createWritePromise(createPttl(key)); | |||
| } | |||
|
|
|||
| /** Removes all elements in the sorted set stored at `key` with a score between `minScore` and `maxScore` (inclusive). | |||
There was a problem hiding this comment.
we should remove the '(inclusive)' - as it depends on the ScoreLimit
barshaul
reviewed
Mar 6, 2024
node/src/Commands.ts
Outdated
| ): redis_request.Command { | ||
| const args = [key]; | ||
|
|
||
| if (minScore == "positiveInfinity") { |
There was a problem hiding this comment.
This code is a duplication of createZcount. Lets move it to a separate function (something like getScoreLimitArg)
barshaul
reviewed
Mar 6, 2024
node/src/Transaction.ts
Outdated
| @@ -936,6 +937,25 @@ export class BaseTransaction<T extends BaseTransaction<T>> { | |||
| return this.addAndReturn(createPttl(key)); | |||
| } | |||
|
|
|||
| /** Removes all elements in the sorted set stored at `key` with a score between `minScore` and `maxScore` (inclusive). | |||
250e203 to
284badc
Compare
|
@barshaul ready |
barshaul
reviewed
Mar 10, 2024
node/src/Commands.ts
Outdated
| if (score == "positiveInfinity") { | ||
| return positiveInfinityArg; | ||
| } else if (score == "negativeInfinity") { | ||
| return negativeInfinityArg; |
There was a problem hiding this comment.
If we have this function I don't see why we need to have the negativeInfinityArg , positiveInfinityArg and isInclusiveArg consts. We don't use them anywhere else, right?
barshaul
approved these changes
Mar 10, 2024
1bc8112 to
e26fc63
Compare
Sa1Gur
pushed a commit
to Sa1Gur/glide-for-redis
that referenced
this pull request
Mar 18, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.