Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing FluentAssertions from dependencies #3013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sa1Gur
Copy link
Contributor

@Sa1Gur Sa1Gur commented Jan 26, 2025

Issue link

Due to recent license change seems reasonable to remove FluentAssertions (although there is not direct danger fluentassertions/fluentassertions#2956). Still it is just couple of code lines

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Guriy Samarin <guriy@amazon.com>
@Sa1Gur Sa1Gur marked this pull request as ready for review January 26, 2025 10:47
@Sa1Gur Sa1Gur requested a review from a team as a code owner January 26, 2025 10:47
Copy link
Collaborator

@asafpamzn asafpamzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.
Looks good to me.

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon added C# C# wrapper testing Everything about testing labels Jan 26, 2025
@Muhammad-awawdi-amazon
Copy link
Collaborator

Hey @Sa1Gur , thanks for the contribution :) appreciated

  • Could you provide more details about the license change?

  • is this change part of a larger effort to standardize on xUnit assertions across the project? If so, are there plans to update other files?

@Sa1Gur
Copy link
Contributor Author

Sa1Gur commented Jan 26, 2025

  1. I’m not entirely certain which link is the most appropriate, but this one seems sufficiently official: Fluent Assertions Releases. Essentially, Fluent Assertions has transitioned to a paid model for commercial use. While this shouldn't currently impact Glide, we might inadvertently restrict our product users over just 5 lines of code. Alternatively, we could avoid updating, but that doesn’t seem ideal either.
  2. I plan to create a PR to update the xUnit version (now that v3 is finally out) and review our usage in conjunction with these changes.

@Muhammad-awawdi-amazon
Copy link
Collaborator

Awesome @Sa1Gur
i'll create a github issue and assign it to you to track the progress 😄
Thanks for bringing this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# C# wrapper testing Everything about testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants