Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: add command SInterStore #2779

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Go: add command SInterStore #2779

merged 6 commits into from
Dec 12, 2024

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Dec 3, 2024

Issue link

This Pull Request is linked to issue (URL): #2831

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

TJ Zhang added 3 commits December 2, 2024 21:28
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review December 4, 2024 03:15
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner December 4, 2024 03:15
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Dec 4, 2024
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - are we planning to update CHANGELOG?

Copy link
Collaborator

@cyip10 cyip10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: tjzhang-BQ <111323543+tjzhang-BQ@users.noreply.github.com>
@tjzhang-BQ tjzhang-BQ merged commit b347ef8 into main Dec 12, 2024
17 checks passed
@tjzhang-BQ tjzhang-BQ deleted the go/tjz-set branch December 12, 2024 00:03
@yipin-chen yipin-chen mentioned this pull request Dec 18, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants