Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add server-modules to npm release #2754

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Node: Add server-modules to npm release #2754

merged 1 commit into from
Nov 26, 2024

Conversation

acarbonetto
Copy link
Contributor

@acarbonetto acarbonetto commented Nov 26, 2024 •
edited
Loading

npm RC release is missing the server-modules definition files:
see: https://www.npmjs.com/package/@valkey/valkey-glide/v/1.2.0-rc16?activeTab=code

With this change, we have the following files in node/npm/glide/build-ts with a build:

index.d.ts	index.js	src

./src:
BaseClient.d.ts		Errors.d.ts		GlideClusterClient.d.ts	ProtobufMessage.d.ts	server-modules
Commands.d.ts		GlideClient.d.ts	Logger.d.ts		Transaction.d.ts

./src/server-modules:
GlideFt.d.ts		GlideFtOptions.d.ts	GlideJson.d.ts

Issue link

This Pull Request is linked to issue (URL): #2755

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • N/A Tests are added or updated.
  • N/A CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@acarbonetto
Node: Add server-modules to npm release
3ad277a 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto acarbonetto added Release blocker Can't release without. node Node.js wrapper 1_2_candidate labels Nov 26, 2024
@acarbonetto acarbonetto added this to the 1.2 milestone Nov 26, 2024
@acarbonetto acarbonetto self-assigned this Nov 26, 2024
@acarbonetto acarbonetto requested a review from a team as a code owner November 26, 2024 00:05
@acarbonetto acarbonetto removed the Release blocker Can't release without. label Nov 26, 2024
@Yury-Fridlyand Yury-Fridlyand linked an issue Nov 26, 2024 that may be closed by this pull request
Node package is missing the Server Modules (FT and JSON) in the 1.2.0 RC packages #2755
Closed
@acarbonetto acarbonetto merged commit 7bd4dcd into release-1.2 Nov 26, 2024
18 of 19 checks passed
@acarbonetto acarbonetto deleted the node/acarbo-add-server-modules-to-package branch November 26, 2024 05:28
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
37773e7 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
99f4a5e 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
362d646 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
12ac866 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
e7396c6 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
03d7db2 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
e473937 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 26, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
f7ff118 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit that referenced this pull request Nov 27, 2024
@acarbonetto @avifenesh
Node: Add server-modules to npm release (#2754)
4bde22c 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Nov 27, 2024
Merged
4 tasks
acarbonetto added a commit that referenced this pull request Nov 27, 2024
@acarbonetto
Node: Add server-modules to npm release (#2754)
1acc108 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@avifenesh avifenesh avifenesh approved these changes

Assignees

@acarbonetto acarbonetto

Labels
node Node.js wrapper
Projects
Valkey-GLIDE - internal
Status: Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Node package is missing the Server Modules (FT and JSON) in the 1.2.0 RC packages
5 participants
@acarbonetto @avifenesh @Yury-Fridlyand @yipin-chen @prateek-kumar-improving