Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: add ARRTRIM command #2550

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Node: add ARRTRIM command #2550

merged 9 commits into from
Oct 31, 2024

Conversation

yipin-chen
Copy link
Collaborator

@yipin-chen yipin-chen commented Oct 30, 2024

Issue link

#2529

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen added the node Node.js wrapper label Oct 30, 2024
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen marked this pull request as ready for review October 30, 2024 23:37
@yipin-chen yipin-chen requested a review from a team as a code owner October 30, 2024 23:37
node/src/server-modules/GlideJson.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideJson.ts Outdated Show resolved Hide resolved
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
node/src/server-modules/GlideJson.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideJson.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideJson.ts Outdated Show resolved Hide resolved
node/src/server-modules/GlideJson.ts Outdated Show resolved Hide resolved
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
node/src/server-modules/GlideJson.ts Outdated Show resolved Hide resolved
* console.log(await GlideJson.get(client, "doc", "$"));
* // Output: '[[],["a"],["a","b"],["a","b"]]' - Returns the value at path '$' in the JSON document stored at `doc`.
* ```
* @example
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 separated example sections? Why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided two examples - one for enhanced syntax path and one for legacy path.

@Yury-Fridlyand Yury-Fridlyand merged commit 23689db into release-1.2 Oct 31, 2024
21 of 22 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/yipin-valkey-456 branch October 31, 2024 23:07
adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request Nov 2, 2024
* Node: add ARRTRIM command

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants