Node: Add command JSON.RESP #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec8a787 to
54ab337
Compare
yipin-chen
approved these changes
Oct 25, 2024
added 5 commits
October 25, 2024 14:46
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
af89c5e to
2695073
Compare
acarbonetto
approved these changes
Oct 28, 2024
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
shohamazon
reviewed
Oct 29, 2024
| client: BaseClient, | ||
| key: GlideString, | ||
| options?: { path: GlideString }, | ||
| ): Promise<ReturnTypeJson<GlideString>> { |
There was a problem hiding this comment.
why is it returning GlideString? the command returns way more than just string, plus we introduced a new return type in #2451
resp is what I call a "universal" commands, can be applied to all types, therefor, ReturnTypeJson is not suitable for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2375
Checklist
Before submitting the PR make sure the following are checked: