Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python - Implement JSON.OBJLEN command functionality #2484

Closed
wants to merge 4 commits into from
Closed

Python - Implement JSON.OBJLEN command functionality #2484

wants to merge 4 commits into from

Conversation

BoazBD
Copy link
Collaborator

@BoazBD BoazBD commented Oct 21, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): 2412

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@BoazBD BoazBD changed the base branch from main to release-1.2 October 21, 2024 13:54
@BoazBD BoazBD force-pushed the json.objlen branch 3 times, most recently from 0821b79 to 90fdb6f Compare October 21, 2024 14:20
@BoazBD BoazBD marked this pull request as ready for review October 21, 2024 14:25
@BoazBD BoazBD requested a review from a team as a code owner October 21, 2024 14:25
@Yury-Fridlyand Yury-Fridlyand added the python Python wrapper label Oct 21, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry

python/python/glide/async_commands/server_modules/json.py Show resolved Hide resolved
python/python/tests/tests_server_modules/test_json.py Show resolved Hide resolved
@Yury-Fridlyand
Copy link
Collaborator

You need to push your branch to this repo (not to your fork) in order to get CI for modules running.

BoazBD added 3 commits October 22, 2024 08:14
@BoazBD
implement JSON.OBJLEN functionality
7a55930 
Signed-off-by: BoazBD <boazbd@amazon.com>
@BoazBD
update chanelog
938c0c4 
Signed-off-by: BoazBD <boazbd@amazon.com>
@BoazBD
Enhance docstring and tests for cases with no path
8f68e84 
Signed-off-by: BoazBD <boazbd@amazon.com>
@BoazBD BoazBD changed the title Implement JSON.OBJLEN command functionality Python - Implement JSON.OBJLEN command functionality Oct 22, 2024
@BoazBD
fix changelog
c73427f 
Signed-off-by: BoazBD <boazbd@amazon.com>
@BoazBD BoazBD closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

Assignees
No one assigned
Labels
python Python wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoazBD @Yury-Fridlyand